fix(cmake): make sure link flags are propagated to module library builds #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CMAKE_SHARED_LINKER_FLAGS_INIT` alone does not populate the link flags for module library targets, i.e.: add_library(foo MODULE) This sets the variable in the crosstool script.
|
All that's failing is the buildifier step but no logs indicating an issue with the code. |
jungleraptor
added a commit
to enfabrica/enkit
that referenced
this pull request
Oct 28, 2024
…#1129) Fixes bazel's linker flags not being passed to CMake module library targets - e.g.: ```cmake add_library(foo MODULE) ``` This can lead to surprising behavior - see: https://github.com/enfabrica/internal/blob/5ac4068d3afad4a662962740981dde0764972c98/bazel/dependencies/rdma-core.BUILD.bazel#L47 Further we can remove the hardcoded linker flags in the above target. We should merge this if upstream takes the fix: bazel-contrib/rules_foreign_cc#1308. Once we upgrade it can be removed.
jsharpe
approved these changes
Nov 18, 2024
|
Thanks for your help getting this merged @jsharpe ! |
jsun-splunk
added a commit
to jsun-splunk/rules_foreign_cc
that referenced
this pull request
Dec 17, 2024
The PR bazel-contrib#1308, added `CMAKE_MODULE_LINKER_FLAGS_INIT` with the value of cxx_linker_shared to the generated toolchain file in CMAKE. This works for most use cases, however, it broke some macos builds that build bundles. This is because the toolchain usually sets "-shared" or "-dynamiclib" while CMAKE sets "-bundle" for Apple platforms. "-bundle" cannot co-exist with the previous two flags.
jsun-splunk
added a commit
to jsun-splunk/rules_foreign_cc
that referenced
this pull request
Dec 17, 2024
The PR bazel-contrib#1308, added `CMAKE_MODULE_LINKER_FLAGS_INIT` with the value of cxx_linker_shared to the generated toolchain file in CMAKE. This works for most use cases, however, it broke some macos builds that build bundles. This is because the toolchain usually sets "-shared" or "-dynamiclib" while CMAKE sets "-bundle" for Apple platforms. "-bundle" cannot co-exist with the previous two flags.
jsun-splunk
added a commit
to jsun-splunk/rules_foreign_cc
that referenced
this pull request
Dec 17, 2024
The PR bazel-contrib#1308, added `CMAKE_MODULE_LINKER_FLAGS_INIT` with the value of cxx_linker_shared to the generated toolchain file in CMAKE. This works for most use cases, however, it broke some macos builds that build bundles. This is because the toolchain usually sets "-shared" or "-dynamiclib" while CMAKE sets "-bundle" for Apple platforms. "-bundle" cannot co-exist with the previous two flags.
jsun-splunk
added a commit
to jsun-splunk/rules_foreign_cc
that referenced
this pull request
Dec 17, 2024
The PR bazel-contrib#1308, added `CMAKE_MODULE_LINKER_FLAGS_INIT` with the value of cxx_linker_shared to the generated toolchain file in CMAKE. This works for most use cases, however, it broke some macos builds that build bundles. This is because the toolchain usually sets "-shared" or "-dynamiclib" while CMAKE sets "-bundle" for Apple platforms. "-bundle" cannot co-exist with the previous two flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_SHARED_LINKER_FLAGS_INITalone does not populate the link flags for module library targets, i.e.:add_library(foo MODULE)This sets the variable in the crosstool script.