correct overeager slash conversion on windows #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novas0x2a
force-pushed
the
fix-slashes
branch
from
93d73c1 to
43cbc80
Compare
|
ping @jsharpe :) |
jsharpe
approved these changes
Nov 1, 2024
auto-merge was automatically disabled
November 1, 2024 18:52
Head branch was pushed to by a user without write access
novas0x2a
force-pushed
the
fix-slashes
branch
from
43cbc80 to
9efdef5
Compare
Bazel's File().path method will return forward-slashed paths; this means if you pass a flag like `"/FI" + f.path` it'll end up looking like `/FIpath/to/thing`; however, _convert_flags was converting all / to -, which ended up breaking the path. This makes sure to only replace the _first_ /.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel's
File().pathmethod will return forward-slashed paths; this means if you pass a flag like"/FI" + f.pathit'll end up looking like/FIpath/to/thing; however,_convert_flagswas converting all/to-, which ended up breaking the path. This makes sure to only replace the first/.