fix undefined variables in the wrap_outputs script #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novas0x2a
force-pushed
the
print-paths
branch
from
9dd0b84 to
63899b3
Compare
|
ping @jsharpe :) |
BUILD_TMPDIR and EXT_BUILD_DEPS were used in the wrapper script, but they weren't actually defined. This wasn't caught because the script prelude (which sets bash -u) wasn't used either. This fix: - Adds the missing script prelude to the wrapper script - Generalizes get_env_prelude slightly so built_tools can use it directly, without needing to override variables - Passes the env prelude to wrapped_outputs so it can set those same variables - Prints out the paths to the build and deps dir at the end of a failed script, to make it easier to debug failed builds.
novas0x2a
force-pushed
the
print-paths
branch
from
63899b3 to
f768d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILD_TMPDIR and EXT_BUILD_DEPS were used in the wrapper script, but they weren't actually defined. This wasn't caught because the script prelude (which sets bash -u) wasn't used either.
This fix: