Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on rules_cc #1269

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Aug 23, 2024

glib_dev was incorrectly loading a symbol from rules_cc which causes visibility issues on windows bzlmod.

@jsharpe jsharpe requested review from jheaff1 and UebelAndre August 23, 2024 21:01
@jsharpe jsharpe requested a review from meteorcloudy August 23, 2024 21:28
@jsharpe
Copy link
Member Author

jsharpe commented Aug 23, 2024

@meteorcloudy - it seems we need to do a bit of work on the bazel_ci_rules bzlmod package as the generated repo has a dev_dependency on rules_cc that isn't declared; I guess the WORKSPACE macro should also be migrated to a extension for proper bzlmod support?

@jsharpe jsharpe mentioned this pull request Aug 24, 2024
@jsharpe
Copy link
Member Author

jsharpe commented Aug 26, 2024

Yes, this is how Bazel uses it: bazelbuild/bazel@master/MODULE.bazel#L354-L364 bazelbuild/bazel@master/rbe_extension.bzl

This only works though because bazel has a dep on rules_cc

@meteorcloudy
Copy link
Contributor

Oh, I see, but isn't rules_cc a nature dependency of rules_foriegn_cc?

@jsharpe
Copy link
Member Author

jsharpe commented Aug 28, 2024

Oh, I see, but isn't rules_cc a nature dependency of rules_foriegn_cc?

Well it does use cc_library and cc_binary but obviously these are available in bazel natively at the moment.. The rules_cc toolchain config is often out of sync with what's in bazel and so I've tended not to take deps on rules_cc.

@jsharpe jsharpe merged commit 24e1bcf into bazel-contrib:main Aug 28, 2024
2 checks passed
@jsharpe jsharpe deleted the rules_cc_dep branch August 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants