Merge user provided CPPFLAGS with build system CPPFLAGS #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allsey87
commented
Aug 14, 2024
foreign_cc/private/make_env_vars.bzl
Outdated
| @@ -82,6 +85,7 @@ _MAKE_FLAGS = { | |||
| "AR_FLAGS": "cxx_linker_static", | |||
| "ASFLAGS": "assemble", | |||
| "CFLAGS": "cc", | |||
| "CPPFLAGS": "", | |||
There was a problem hiding this comment.
What do you think about this @jsharpe? It is a bit of a hack that exploits that getattr(flags, _MAKE_FLAGS[flag], []) below will default to an empty list since an attribute cannot have an empty key.
There was a problem hiding this comment.
I have changed this in 799f91c, I think it is better to be more explicit here.
jsharpe
approved these changes
Aug 14, 2024
|
@allsey87 if you update this branch then it will auto merge once CI has run - I don't have permissions on your fork to update it myself. |
jsharpe
pushed a commit
to jsharpe/rules_foreign_cc
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR regarding flags being set in
env. Currently there is no solution to setCPPFLAGSviaconfigure_make. If you set them in the environment, they will be clobbered by the build system flags. If you set them viaconfigure_optionsorconfigure_prefix(I saw someone doing that somewhere), then they clobber the build systemCPPFLAGSmeaning you cannot use dependencies (since this is how header files from dependencies are made during the build).