autotools: return darwin as os instead of cmake in xcompile #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 10d47d4, I justified returning macos instead of darwin because config.sub left it alone. Unfortunately, I immediately have to eat my words because I already discovered a macro that breaks with this; libffi has a custom macro (https://github.com/libffi/libffi/blob/8e3ef965c2d0015ed129a06d0f11f30c2120a413/acinclude.m4#L40) that doesn't handle macos, just darwin. I considered returning just darwin but that also runs afoul of a check, this time in gcc's version of libtool.m4 (https://github.com/gcc-mirror/gcc/blob/3f1e15e885185ad63a67c7fe423d2a0b4d8da101/libtool.m4#L1071) Therefore, I chose to return darwin21, which is Monterey, the current oldest non-eol version of darwin.
jsharpe
approved these changes
Aug 13, 2024
jsharpe
pushed a commit
to jsharpe/rules_foreign_cc
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 10d47d4, I justified returning macos instead of darwin because config.sub left it alone. Unfortunately, I immediately have to eat my words because I already discovered a macro that breaks with this; libffi has a custom macro
(https://github.com/libffi/libffi/blob/8e3ef965c2d0015ed129a06d0f11f30c2120a413/acinclude.m4#L40) that doesn't handle macos, just darwin.
I considered returning just darwin but that also runs afoul of a check, this time in gcc's version of libtool.m4
(https://github.com/gcc-mirror/gcc/blob/3f1e15e885185ad63a67c7fe423d2a0b4d8da101/libtool.m4#L1071)
Therefore, I chose to return darwin21, which is Monterey, the current oldest non-eol version of darwin.