Portable copy_dir_contents_to_dir #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Lam <[email protected]>
Signed-off-by: Thomas Lam <[email protected]>
jsharpe
force-pushed
the
macos-portable-cp
branch
from
6d1b244 to
164d5a8
Compare
jsharpe
added a commit
to jsharpe/rules_foreign_cc
that referenced
this pull request
Aug 23, 2024
Co-authored-by: James Sharpe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On BSD-based distro/MacOS, using
cp -L -R {source}/ignores files or directories with a leading dot. If users have GNU-based coreutils installed on their BSD/Mac system (via Nix for e.g.),cp -L -R {source}/would also copy the source directory underneath the target directory, which is not what we want.This PR changes both the
copy_dir_contents_to_dirimplementation for BSD and MacOS such that it works regardless of whether user has GNU or BSD coreutils installed.