-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for cc_shared_library deps #1243
Conversation
This looks great! |
this commit is helpful, can guys fix check failed, then merge it into master? |
There is still an issue I am trying to fix with the output CcInfo. This can't be merged yet. |
45b0783
to
3f163d0
Compare
I fixed the output issue and added an example. I did however notice |
4471462
to
812c98c
Compare
I assume this is a blocker for adding cc_shared_library support |
Sigh, yes; as this even requires enforcing an experimental flag in bazel 6 as even if we went via rules_cc I think the act of referencing a cc_shared_library Provider will trigger the flag needing to be set in bazel 6? |
4ae7f25
to
fb72e78
Compare
I have managed to work around this via bazel_features. I added CcSharedLibraryInfo to globals: bazel-contrib/bazel_features@4f01bd6 Which we can now reference and prevent earlier bazel versions from failing when compiling .bzl. The part I don't get is how to add the bazel_features dep to stardoc. See https://buildkite.com/bazel/rules-foreign-cc/builds/5889#019143a7-0041-4a33-b20a-d01ec4779041 |
I think you need to add bazel_features to the docs WORKSPACE file? |
cdc809e
to
f883976
Compare
Yes I tried this but it's still failing... |
Hmm, I'm not sure then - understanding the docs generation is on my TODO list as its failing to run on main.. @UebelAndre can you remember how the docs gen works as you put it together originally IIRC? |
f883976
to
7227f43
Compare
7227f43
to
6dc2427
Compare
Fixed - it was an error in the I wasn't using the |
This MR adds a new
dynamic_deps
attr that allows the libs created by cc_shared_library targets to be added as deps.Closes #1242