Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit mention of bazel 4.x support #1146

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Remove explicit mention of bazel 4.x support #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97da3aa
Remove explicit mention of bazel 4.x support
jsharpe Dec 21, 2023
5c08f43
Merge branch 'main' into bazel4x
jsharpe Dec 21, 2023
5d65a5f
Merge branch 'main' into bazel4x
jsharpe Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ Documentation for all rules and providers are available at: https://bazelbuild.g

## Bazel versions compatibility

Works with Bazel after 4.2.0.

The following flags are required in Bazel 4.x but not Bazel 5.x or newer:

- `--experimental_enable_aggregating_middleman=False`
Works with Bazel after 5.4.0.

Note that the rules may be compatible with older versions of Bazel but support may break
in future changes as these older versions are not tested.
Expand Down
8 changes: 0 additions & 8 deletions examples/WORKSPACE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,6 @@ rbe_preconfig(
toolchain = "ubuntu1804-bazel-java11",
)

# TODO: Remove once bazel 4.x is no longer supported
http_archive(
name = "rules_proto",
sha256 = "20b240eba17a36be4b0b22635aca63053913d5c1ee36e16be36499d167a2f533",
strip_prefix = "rules_proto-11bf7c25e666dd7ddacbcd4d4c4a9de7a25175f8",
urls = ["https://github.com/bazelbuild/rules_proto/archive/11bf7c25e666dd7ddacbcd4d4c4a9de7a25175f8.tar.gz"],
)

http_archive(
name = "build_bazel_apple_support",
patches = ["//deps:apple_support.patch"],
Expand Down