Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use variable expansion on generator args #1087

Conversation

lummax
Copy link
Contributor

@lummax lummax commented Aug 29, 2023

No description provided.

@lummax lummax force-pushed the lummax-cmake-expand-cache-entries-and-generator-args branch from 504c76e to f74ea8c Compare August 30, 2023 07:18
@lummax lummax changed the title cmake: use variable expansion on cache entries and generator args cmake: use variable expansion on generator args Aug 30, 2023
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jsharpe jsharpe enabled auto-merge (squash) October 14, 2023 14:26
@jsharpe jsharpe merged commit bac2c19 into bazel-contrib:main Oct 14, 2023
1 check passed
@kmARC
Copy link

kmARC commented Jun 18, 2024

This commit breaks absolute paths registered with native_tool_toolchain. See #1218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants