fix linux cross compiling on macos #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as bazel-contrib#997 but for linux instead of android.
jungleraptor
commented
Jun 23, 2023
|
|
||
| _TARGET_ARCH_PARAMS = { | ||
| "aarch64": { | ||
| "CMAKE_SYSTEM_PROCESSOR": "aarch64", |
There was a problem hiding this comment.
There's a little more nuance to it than this (mostly on mac) but I think this is a good enough start.
|
nice, looks reasonable to me, I don't have access here tho, @jsharpe I think is the right contact |
jungleraptor
commented
Jun 23, 2023
| # by setting CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR, | ||
| # see https://github.com/bazelbuild/rules_foreign_cc/issues/289, | ||
| # and https://github.com/bazelbuild/rules_foreign_cc/pull/1062 | ||
| if target_os != host_os and target_os != "unknown": |
There was a problem hiding this comment.
There's more to it than this (i.e. linux-x86_64 -> linux-aarch64).
Probably should be a function like is_cross_compilation and handle this more rigorously.
|
This is on my radar to review - will try to take a look at some point this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cross-compiling from macos to linux.
see #997 for background.
I had to make a couple of extra changes to support this:
CMAKE_SYSTEM_NAMEmanually causesCMAKE_SYSTEM_PROCESSORto not be set. This breaks some builds that expect this variable to be set like libjpeg-turbo.rules_foreign_cconly takes on responsibility of setting them when necessary.