Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests that depend on shared libraries #1016

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Remove tests that depend on shared libraries #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84bd538
Remove tests that depend on shared libraries, which currently dont work
jheaff1 Feb 21, 2023
b73db94
Update archive sha and strip prefix
jheaff1 Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .bazelci/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ tasks:
macos_targets: &macos_targets_standalone
- "//..."
- "//:third_party_examples_macos_tests"
# Remove tests that depend on shared libraries, which currently doesn't work on MacOS - https://github.com/bazelbuild/bazel/issues/10254
- "-@rules_foreign_cc_examples_third_party//curl:curl_test"
- "-@rules_foreign_cc_examples_third_party//openssl:openssl_test"
build_targets: *macos_targets_standalone
build_flags:
- "-c"
Expand All @@ -92,7 +95,7 @@ tasks:
macos_targets: &macos_targets
- "//..."
- "//:third_party_examples_macos_tests"
# Remove tests that depend on shared libraries, which currently doesn't work on sandboxed MacOS - https://github.com/bazelbuild/bazel/issues/10254
# Remove tests that depend on shared libraries, which currently doesn't work on MacOS - https://github.com/bazelbuild/bazel/issues/10254
- "-@rules_foreign_cc_examples_third_party//curl:curl_test"
- "-@rules_foreign_cc_examples_third_party//openssl:openssl_test"
build_targets: *macos_targets
Expand Down
4 changes: 2 additions & 2 deletions examples/third_party/iconv/iconv_repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def iconv_repositories():
"https://opensource.apple.com/tarballs/libiconv/libiconv-59.tar.gz",
],
type = "tar.gz",
sha256 = "f7729999a9f2adc8c158012bc4bc8d69bea5dec88c8203cdd62067f91ed60b43",
strip_prefix = "libiconv-59/libiconv",
sha256 = "975f31be8eb193d5099b5fc4fc343b95c0eb83d59ffa6e5bde9454def2228a53",
strip_prefix = "libiconv-libiconv-59/libiconv",
build_file = Label("//iconv:BUILD.iconv.macos.bazel"),
)