Disable fdo features. #1002
Merged
Disable fdo features. #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdo_instrument and fdo_optimize features should be disabled. These are not supported by external build systems.
copybara-service bot
pushed a commit
to google/fleetbench
that referenced
this pull request
Jan 26, 2023
libpfm is a make-based project wrapped by the foreign_cc rules, which doesn't support the FDO instrumentation flags. The latest version of rules_foreign_cc includes bazel-contrib/rules_foreign_cc#1002 which silently drops the FDO flags for foreign targets. This allows us to set --fdo_instrument / --fdo_optimize flags as well as --define=pfm=1. PiperOrigin-RevId: 504700102 Change-Id: I3acd19d367cc65f7241449a55cd3e500a65c4b5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fdo_instrument and fdo_optimize features should be disabled. These are not supported by external build systems.