Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native.sh_binary missing in Bazel 8.0.0rcN #1336

Closed
johan-vcc opened this issue Dec 6, 2024 · 0 comments · Fixed by #1337
Closed

native.sh_binary missing in Bazel 8.0.0rcN #1336

johan-vcc opened this issue Dec 6, 2024 · 0 comments · Fixed by #1337

Comments

@johan-vcc
Copy link

johan-vcc commented Dec 6, 2024

When testing Bazel 8.0.0 release candidates (currently rc7) we noticed that native.sh_binary is not found here:

ERROR: Traceback (most recent call last):
        File "/home/jnils/.cache/bazel/_bazel_jnils/77d7916d7a03bde8b8c7c52bce9b1508/external/rules_foreign_cc+/toolchains/private/BUILD.bazel", line 158, column 15, in <toplevel>
                pkgconfig_tool(
        File "/home/jnils/.cache/bazel/_bazel_jnils/77d7916d7a03bde8b8c7c52bce9b1508/external/rules_foreign_cc+/foreign_cc/built_tools/pkgconfig_build.bzl", line 164, column 20, in pkgconfig_tool
                runnable_binary(
        File "/home/jnils/.cache/bazel/_bazel_jnils/77d7916d7a03bde8b8c7c52bce9b1508/external/rules_foreign_cc+/foreign_cc/utils.bzl", line 61, column 11, in runnable_binary
                native.sh_binary(
Error: no native function or rule 'sh_binary'

We are currently running rules_foreign_cc version 0.10.1 but I see that native.sh_binary is used in the latest main as well.
This is probably something that needs to be updated for compatibility with Bazel 8.0.0.
Loading rules_shell would fix this problem. See bazelbuild/bazel@c56eeeb

jsharpe added a commit to jsharpe/rules_foreign_cc that referenced this issue Dec 6, 2024
This is needed for bazel 8.

Fixes bazel-contrib#1336
jsharpe added a commit to jsharpe/rules_foreign_cc that referenced this issue Dec 6, 2024
This is needed for bazel 8.

Fixes bazel-contrib#1336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant