Skip to content

Commit

Permalink
Fix _get_make_variables ignoring user environment variables (#1230)
Browse files Browse the repository at this point in the history
Co-authored-by: James Sharpe <[email protected]>
  • Loading branch information
allsey87 and jsharpe authored Aug 12, 2024
1 parent 3ffc4bd commit d70efd6
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions foreign_cc/private/make_env_vars.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,14 @@ def _get_make_variables(workspace_name, tools, flags, user_env_vars, make_comman
vars = {}

for flag in _MAKE_FLAGS:
flag_value = getattr(flags, _MAKE_FLAGS[flag])
if flag_value:
vars[flag] = flag_value

# Merge flags lists
for user_var in user_env_vars:
toolchain_val = vars.get(user_var)
if toolchain_val:
vars[user_var] = toolchain_val + [user_env_vars[user_var]]
toolchain_flags = getattr(flags, _MAKE_FLAGS[flag], [])
user_flags = [
user_flag
for user_flag in user_env_vars.get(flag, "").split(" ")
if user_flag
]
if toolchain_flags or user_flags:
vars[flag] = toolchain_flags + user_flags

tools_dict = {}
for tool in _MAKE_TOOLS:
Expand Down

0 comments on commit d70efd6

Please sign in to comment.