Skip to content

Commit

Permalink
fix: Allow cuda_test to specify the data attribute. (#314)
Browse files Browse the repository at this point in the history
The native.cc_test rule has a `data` attribute that is not exposed in
the cuda_test rule. This change allows the cuda_test rule to specify the
`data` attribute, and plumb it down to the native.cc_test rule.
  • Loading branch information
bgianfo authored Jan 27, 2025
1 parent 6e117d0 commit 1b36a26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cuda/private/macros/cuda_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def cuda_test(name, **attrs):
}

# https://bazel.build/reference/be/common-definitions?hl=en#common-attributes-tests
cc_test_only_attrs = ["args", "env", "env_inherit", "size", "timeout", "flaky", "shard_count", "local"]
cc_test_only_attrs = ["args", "env", "env_inherit", "size", "timeout", "flaky", "shard_count", "local", "data"]

cuda_library_attrs = {k: v for k, v in attrs.items() if k not in cc_test_only_attrs}
for attr in cuda_library_only_attrs_defaults:
Expand Down

0 comments on commit 1b36a26

Please sign in to comment.