Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the OS and arch check for Bazel binary download #202

Merged
merged 5 commits into from
Sep 12, 2023
Merged

fix: update the OS and arch check for Bazel binary download #202

merged 5 commits into from
Sep 12, 2023

Conversation

cgrindel
Copy link
Member

@cgrindel cgrindel commented Sep 7, 2023 •
edited
Loading

  • Refactor the checks to helper functions.
  • Reliably identify arm and amd64 arches.

Closes #194.

@cgrindel cgrindel self-assigned this Sep 7, 2023
@cgrindel cgrindel mentioned this pull request Sep 7, 2023
Closed
katre
katre approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgrindel cgrindel marked this pull request as ready for review September 8, 2023 19:57
@cgrindel cgrindel requested a review from kormide September 8, 2023 19:57
@cgrindel cgrindel enabled auto-merge (squash) September 8, 2023 19:58
@cgrindel cgrindel disabled auto-merge September 8, 2023 19:58
@cgrindel cgrindel changed the title fix: update the arch check for MacOS fix: update the OS and arch check for Bazel binary download Sep 8, 2023
@cgrindel cgrindel enabled auto-merge (squash) September 8, 2023 19:59
@katre katre mentioned this pull request Sep 12, 2023
Closed
@katre
Copy link
Collaborator

katre commented Sep 12, 2023

Are there any remaining concerns here, or can this be merged? I'd like to fix the failure in rules_android.

@cgrindel
Copy link
Member Author

Are there any remaining concerns here, or can this be merged? I'd like to fix the failure in rules_android.

I was just waiting to get an approval that will allow it to merge. I was going to ping some other folks if @kormide does not have time.

@cgrindel
Copy link
Member Author

I will cut a release once this merges.

@cgrindel cgrindel merged commit 5ae918e into main Sep 12, 2023
@cgrindel cgrindel deleted the gh194_macos_arm_error branch September 12, 2023 15:07
cgrindel added a commit to k1nkreet/rules_bazel_integration_test that referenced this pull request Sep 27, 2023
@cgrindel
fix: update the OS and arch check for Bazel binary download (bazel-co…
1281b8c 
…ntrib#202)

- Refactor the checks to helper functions.
- Reliably identify arm and amd64 arches.

Related to bazel-contrib#194.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormide kormide kormide approved these changes

@katre katre katre approved these changes

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests dont work on mac os
3 participants
@cgrindel @katre @kormide