feat: provide stable-named job for branch protection #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub actions matrix "test" gets expanded to many status checks, making it impossible to keep the branch protection settings in the GitHub UI up-to-date as the matrix cells are updated. This provides a "conclusion" status which can be used instead. Thanks @mattmoor for the code!
alexeagle
commented
Jul 3, 2024
.github/workflows/ci.yaml
Outdated
| working-directory: /tmp | ||
| run: echo ${{ env.WORKFLOW_CONCLUSION }} && exit 0 | ||
|
|
||
| - if: ${{ env.WORKFLOW_CONCLUSION == 'failure' }} |
There was a problem hiding this comment.
note: this is copied from what Chainguard folks are using.
https://github.com/technote-space/workflow-conclusion-action/blob/main/src/constant.ts is the list of the possible values
mattmoor
approved these changes
Jul 3, 2024
jsharpe
reviewed
Jul 3, 2024
kormide
requested changes
Jul 19, 2024
kormide
approved these changes
Jul 19, 2024
alexeagle
added a commit
to bazel-contrib/bazel-lib
that referenced
this pull request
Jul 20, 2024
alexeagle
added a commit
to bazel-contrib/bazel-lib
that referenced
this pull request
Sep 18, 2024
alexeagle
added a commit
to aspect-build/rules_js
that referenced
this pull request
Sep 21, 2024
alexeagle
added a commit
to aspect-build/rules_js
that referenced
this pull request
Sep 21, 2024
alexeagle
added a commit
to aspect-build/rules_js
that referenced
this pull request
Sep 21, 2024
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Sep 21, 2024
alexeagle
added a commit
to aspect-build/rules_js
that referenced
this pull request
Oct 3, 2024
alexeagle
added a commit
to aspect-build/rules_ts
that referenced
this pull request
Oct 3, 2024
alexeagle
added a commit
to aspect-build/rules_py
that referenced
this pull request
Nov 20, 2024
Allows branch protection on outcome of the entire matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub actions matrix "test" gets expanded to many status checks, making it impossible to keep the branch protection settings in the GitHub UI up-to-date as the matrix cells are updated.
This provides a "conclusion" status which can be used instead. Thanks @mattmoor for the code!
Demo: https://github.com/bazel-contrib/rules-template/actions/runs/9783272801/job/27011588324?pr=124