Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use PyInfo from rules-python #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

honnix
Copy link

@honnix honnix commented Dec 6, 2024

Depending on bazel and configuration, PyInfo is either the starlark implementation or built-in, which makes the code more compatible.

load("@aspect_rules_py//py:defs.bzl", "py_binary")

py_binary(
    name = "hello-world",
    ...
)

mypy_test(
    name = "hello-world-mypy",
    deps = [
        ":hello-world",
    ],
)

The above code fails because aspect_rule_py use PyInfo from rules_python.

@honnix honnix force-pushed the use-pyinfo-from-rules-py branch from 1f3af72 to f6bd961 Compare December 6, 2024 15:58
@honnix honnix marked this pull request as ready for review December 6, 2024 16:06
@honnix
Copy link
Author

honnix commented Dec 6, 2024

@alexeagle Does this change make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant