Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency go to v1.23.4 #980

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 6, 2024

This PR contains the following updates:

Package Type Update Change
go (source) toolchain patch 1.23.2 -> 1.23.4

Release Notes

golang/go (go)

v1.23.4

v1.23.3


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the deps Renovate PRs label Nov 6, 2024
@renovate renovate bot changed the title chore(deps): update dependency go to v1.23.3 chore(deps): update dependency go to v1.23.4 Dec 4, 2024
Copy link
Contributor Author

renovate bot commented Dec 6, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@alexeagle
Copy link
Collaborator

@fmeum is there a better recommendation to align the Go toolchain version between Bazel/non-Bazel? I didn't even add any assertion here.

For rules_ts we do something to read the canonical file, so it would be like

go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(version_from = "//:go.mod") # Reads the "toolchain" line

@alexeagle alexeagle self-requested a review December 6, 2024 17:24
@fmeum
Copy link
Member

fmeum commented Dec 6, 2024

Not yet, but I've been working on this over at bazel-contrib/rules_go#4106. It's a bit more difficult for Go as there are two relevant versions, the SDK and the language version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Renovate PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants