Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify distro/release #12

Closed
alexeagle opened this issue Dec 11, 2021 · 0 comments · Fixed by #13
Closed

Simplify distro/release #12

alexeagle opened this issue Dec 11, 2021 · 0 comments · Fixed by #13

Comments

@alexeagle
Copy link
Collaborator

From bazel-contrib/SIG-rules-authors#11 I learned that it's overkill for us to build a distribution artifact.

The only reasons to bother are:

  • users can bazel query @aspect_bazel_lib//... and not trip on our load() statement from stardoc. But users ~never do that.
  • the distribution is smaller since docs and tests aren't included. But we're talking dozens of kilobytes which isn't worth the complexity.

All my remaining reasons for it turned out to be wrong. Trying the simplification here.

Proof of what we need to do when generating a workspace snippet:

alexeagle@system76-pc:~/Projects/bazel-lib$ git archive --format=tar --prefix=bazel-lib-0.2.7/ v0.2.7 | gzip > /tmp/tarball.tgz; sha256sum /tmp/tarball.tgz
ce379ba06f861f5cab773862fc8eaeff3a531e744e2076165f4bbef4cb7ac046  /tmp/tarball.tgz

alexeagle@system76-pc:~/Projects/bazel-lib$ curl -L https://github.com/aspect-build/bazel-lib/archive/v0.2.7.tar.gz|sha256sum -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   130  100   130    0     0    431      0 --:--:-- --:--:-- --:--:--   430
100 29335    0 29335    0     0  43588      0 --:--:-- --:--:-- --:--:-- 43588
ce379ba06f861f5cab773862fc8eaeff3a531e744e2076165f4bbef4cb7ac046  -

/cc @cgrindel

alexeagle added a commit that referenced this issue Dec 11, 2021
alexeagle added a commit that referenced this issue Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant