cmd/gazelle: hack to fix repository name hfor @go_googleapis #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, Gazelle detects the repository name by reading the WORKSPACE file and looking for a workspace rule. In go_googleapis, the proper workspace name is com_google_googleapis. Before bazel-contrib/rules_go#2355, we patched the WORKSPACE file before running Gazelle so the repository name would be set to go_googleapis. Unfortunately, in newer versions of Bazel, WORKSPACE is overwritten, so the patch doesn't apply. This change just adds a hack to set the repository name to go_googleapis if com_google_googleapis is detected. Updates bazel-contrib/rules_go#2387
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
Feb 26, 2020
Re-generate the Gazelle patch after bazel-contrib/bazel-gazelle#717. Fixes bazel-contrib#2387
jayconrod
pushed a commit
to bazel-contrib/rules_go
that referenced
this pull request
Feb 26, 2020
Re-generate the Gazelle patch after bazel-contrib/bazel-gazelle#717. Fixes #2387
jayconrod
pushed a commit
to bazel-contrib/rules_go
that referenced
this pull request
Feb 26, 2020
Re-generate the Gazelle patch after bazel-contrib/bazel-gazelle#717. Fixes #2387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, Gazelle detects the repository name by reading the WORKSPACE
file and looking for a workspace rule. In go_googleapis, the proper
workspace name is com_google_googleapis. Before
bazel-contrib/rules_go#2355, we patched the WORKSPACE file before running
Gazelle so the repository name would be set to
go_googleapis. Unfortunately, in newer versions of Bazel, WORKSPACE is
overwritten, so the patch doesn't apply.
This change just adds a hack to set the repository name to
go_googleapis if com_google_googleapis is detected.
Updates bazel-contrib/rules_go#2387