update version of rules_go #1940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
update-rules-go-in-gazelle
branch
from
ed1731b to
d3dab59
Compare
francine-blanc
force-pushed
the
update-rules-go-in-gazelle
branch
from
d3dab59 to
293a67e
Compare
|
Sorry, forgot about your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
language/go
cmd/gazelle
What does this PR do? Why is it needed?
This is a small PR to update the version of
rules_goused bygazellefor bzlmod.When more known platforms were added in this PR: #1853, the version of
rules_goin theMODULE.bazelwas not updated to 0.50.1 (the earliest release the change appears in). This means that althoughgazelledepends on a newer version ofrules_go, which pulls in all of these additional platforms, without the newer version ofrules_gobeing referenced in theMODULE.bazel, errors such as the following are seen:no such target '@@rules_go~//go/platform:qnx': target 'qnx' not declared in package 'go/platform'when attempting to build a binary with a go_dependency that refers to these platforms.Which issues(s) does this PR fix?
n/a
Other notes for review