Migrate to Documenter@1
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strict` The `strict` keyword argument is no longer supported as of `Documenter@1`[^1]. The `warnonly` keyword argument is its replacement. When running in CI all errors should be critical, which is the default, but when not they reported as warnings so they can be resolved locally without failing the build to make it easier to make more extensive changes to the documentation using `LiveServer` which would otherwise error as well. [^1]: https://github.com/JuliaDocs/Documenter.jl/blob/master/CHANGELOG.md#breaking
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #52 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 5 5
Lines 147 147
=============================================
Hits 147 147 ☔ View full report in Codecov by Sentry. |
bauglir
force-pushed
the
migrate-to-documenter-v1
branch
2 times, most recently
from
8d7d93c to
58f49bf
Compare
bauglir
force-pushed
the
migrate-to-documenter-v1
branch
from
58f49bf to
dc42ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenter@1has been out for a while now and it is about time the package migrates to it to ensure it is compatible (which it is).The new behavior of
Documenterwriting images to files, JuliaDocs/Documenter.jl#2143, also fixes a recent issue with Structurizr diagrams no longer being properly rendered due to character sequences they include.