close journald when reading

when reading from journald, we need to close the journal handler for events and logging. Fixes: containers#8864 Signed-off-by: baude <[email protected]>
baude · Jan 4, 2021 · 002d0d6 · 002d0d6
1 parent f261bfc
commit 002d0d6
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/libpod/events/journal_linux.go b/libpod/events/journal_linux.go
@@ -84,7 +84,11 @@ func (e EventJournalD) Read(ctx context.Context, options ReadOptions) error {
 	if err != nil {
 		return err
 	}
-
+	defer func() {
+		if err := j.Close(); err != nil {
+			logrus.Errorf("Unable to close journal :%v", err)
+		}
+	}()
 	// match only podman journal entries
 	podmanJournal := sdjournal.Match{Field: "SYSLOG_IDENTIFIER", Value: "podman"}
 	if err := j.AddMatch(podmanJournal.String()); err != nil {
@@ -112,7 +116,6 @@ func (e EventJournalD) Read(ctx context.Context, options ReadOptions) error {
 	if err != nil {
 		return errors.Wrap(err, "failed to get journal cursor")
 	}
-
 	for {
 		select {
 		case <-ctx.Done():