-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add assert_stderr and assert_stderr_line #52
Conversation
@martin-schulze-vireso This PR is ready. Can you review it? |
- bats-assert use [my fork](https://github.com/adoyle-h/bats-assert.git), waiting the [PR](bats-core/bats-assert#52) merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike the amount of code duplication. Can we have a central implementation that is used by both assert_output and assert_stderr (and _lines likewise)? Similarly, I'd fold the documentation into assert_output's or link to it from there. Feature changes will sooner or later get lost on one of the two duplicates.
@adoyle-h Do you plan to work on this? |
Sorry, I'm occupied with work. |
Hi @martin-schulze-vireso |
If you are willing to work in this, you can use the code as starting point but have to open your own PR. I don't have the time to do so myself right now. |
Hi @martin-schulze-vireso started working on this
I think this wil allows to reuse most of assert_output in bats-assert/src/assert_output.bash Lines 124 to 197 in e2d855b
also we can define an "alias" for assert_stderr => assert_output --stderr
|
see #69 |
fix #42