Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unsupported v1 support #910

Merged
merged 1 commit into from
Jun 23, 2024
Merged

delete unsupported v1 support #910

merged 1 commit into from
Jun 23, 2024

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Jun 23, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@batfish-bot
Copy link

This change is Reviewable

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (3e97f77) to head (902ab7b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   85.73%   87.00%   +1.26%     
==========================================
  Files          25       24       -1     
  Lines        3758     3654     -104     
  Branches      795      770      -25     
==========================================
- Hits         3222     3179      -43     
+ Misses        390      339      -51     
+ Partials      146      136      -10     
Files Coverage Δ
pybatfish/client/internal.py 78.94% <100.00%> (+9.38%) ⬆️
pybatfish/client/session.py 81.10% <100.00%> (+3.52%) ⬆️
pybatfish/client/workhelper.py 69.18% <100.00%> (+3.80%) ⬆️

@dhalperi dhalperi force-pushed the spr/master/1d55691b branch from 1ffe624 to 38503cb Compare June 23, 2024 18:20
@dhalperi dhalperi force-pushed the spr/master/b54364a9 branch from 330cf20 to 35d830b Compare June 23, 2024 19:51
@dhalperi dhalperi force-pushed the spr/master/1d55691b branch from 38503cb to 91a964f Compare June 23, 2024 19:51
Base automatically changed from spr/master/b54364a9 to master June 23, 2024 20:03
commit-id:1d55691b
@dhalperi dhalperi force-pushed the spr/master/1d55691b branch from 91a964f to 902ab7b Compare June 23, 2024 20:04
@dhalperi dhalperi enabled auto-merge (squash) June 23, 2024 20:04
@dhalperi dhalperi requested review from ratulm and progwriter June 23, 2024 20:04
This was referenced Jun 23, 2024
Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@dhalperi dhalperi merged commit 4648ff8 into master Jun 23, 2024
32 checks passed
@dhalperi dhalperi deleted the spr/master/1d55691b branch June 23, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants