Config with template variables #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is neat! Thank you for your contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to use environment variables in the
config.jswhich are evaluated once when starting the docker container. This feature only applies toconfig.js.templateand generateconfig.jswhen the container is started. Existing configurations should not be affected by this new feature (opt-in).The environment variables are replaced with the linux
envsubsttool, which uses Shell variable syntax ($nameand${name}) and the variables are given via the environment.envsubstonly replaces the variables and does nothing extra such as bash substitution expressions or default values.MagicMirrorOrg/MagicMirror#1947