Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module directory checking and updating #13

Closed
topjor opened this issue Oct 6, 2018 · 1 comment · Fixed by #25
Closed

Module directory checking and updating #13

topjor opened this issue Oct 6, 2018 · 1 comment · Fixed by #25
Assignees
Labels

Comments

@topjor
Copy link

topjor commented Oct 6, 2018

After seeing a update message, I thought about updating my container and checked your repo first to see if it handled updating the default modules.
Looking at this script, you are checking if /opt/magic_mirror/modules is a regular file, not a directory

if [ ! -f /opt/magic_mirror/modules ]; then

This means every time the entry script is invoked it will copy over everything from /opt/default_modules/. This also does not account for files that are not present anymore in the defaults

I forked your repo to see if I could come up with a way of solving the issue, so far i have changed the check to see if the /opt/magic_mirror/modules/default folder exists and move all my modules in a sub folder, but that makes adding modules also more complicated, requiring the subdir in the name or compiling a js file that defines all modules like the default folder has (this would involve making a script to compile this file each boot).

Another idea was to store and check for a version file in the module directory to see if it needs updating.

What do you think would be a good idea to go about solving this?

@bastilimbach bastilimbach self-assigned this Oct 11, 2018
@bastilimbach
Copy link
Owner

Thanks for reporting the issue. I'll take a look at this next week 👍

xbgmsharp pushed a commit to xbgmsharp/docker-MagicMirror that referenced this issue Mar 4, 2019
Update entrypoint to check for valid directory bastilimbach#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants