WIP: automatically build libsndfile 1.1.0 on the CI with MP3 support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build and upload Windows libs.
According to the libsndfile documentation, the function sf_open_fd only works on Windows, if the libsndfile DLL is linked against the same version of the Microsoft C runtime DLL as python is. For Python 3.5+, this is Visual Studio 14.x, which is what this commit provides.
this seems to correctly build mpg123 and liblame, but none of the custom-built libraries are picked up by the libsndfile configure script. Possibly due to changes in libsndfile's build scripts?
because 2016 is deprecated and no longer builds
These are the latest CI builds for libsndfile 1.1.0 with MP3 support
The default still seems to be 1.0.31
Maybe that will make libsndfile 1.1.0 available?
|
@bastibe i was trying to build a macOS arm build on my m1. I had to remove
|
add macos arm64 build
…bsndfile-binaries into faroit-faroit/1.1.0-build-add_mac_arm
|
That looks promising! As far as I can tell, some people have managed to somehow get M1 runners working in the Github CI! To be honest, I don't fully understand how, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates build scripts and dependencies to build version 1.1.0 of libsndfile.
Working:
Workaround:
The windows builds rely on VCPKG to build libsndfile. VCPKG has been updated to libsndfile 1.1.0.
The macOS builder builds libsndfile on an Intel machine, and as far as I know, there aren't any macOS/arm runners available. Presumably, it should be possible to cross-compile arm binaries from an Intel machine, but I do not know how.
If you know how to cross-compile libsndfile and its dependencies from the macOS/Intel runners, please let me know! Providing a hand-built arm binary is also an option.