Yokozuna/KV isolation #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llelf do you still maintain an interest in yoko? Do you want to review this change, and the related PR in riak_kv? The intention is to move this into Riak KV 2.9.1 and then roll into 3.0 |
llelf
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of b715906
This adds the hook code so that yokozuna can be used with the isolated hooks in https://github.com/basho/riak_kv/tree/fd-remove-yz-dep-develop29
This a feature that was previously merged in to develop by basho old. It allows for the removal of yokozuna references from riak_kv. This will then allow in the future for riak_kv to be packaged without yokozuna in environments where solr is not used, and there is no future intention of using it.
The combined branches pass all yoko_all tests (except the solr_upgrade_downgrade test which tests and upgrade from a legacy solr version - but this also fails in develop-2.9). Packaging riak without yokozuna passes all kv_all riak_test tests.