Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subcommand to find oldest entries in GC bucket #1160

Merged
merged 3 commits into from
Jun 25, 2015
Merged

Add subcommand to find oldest entries in GC bucket #1160

merged 3 commits into from
Jun 25, 2015

Conversation

kuenishi
Copy link
Contributor

@kuenishi kuenishi commented Jun 5, 2015

Will follow with tests.

@kuenishi kuenishi added this to the 2.1.0 milestone Jun 5, 2015
@Basho-JIRA
Copy link

The name 'riak-cs-admin gc oldest-entries' is not sort of a cool name. Any good ideas? https://github.com/basho/riak_cs/pull/1160/files#diff-75a89dfe97761f3c8ca18ff38b38fdf1R26

_[posted via JIRA by Kota Uenishi]_

@kuenishi
Copy link
Contributor Author

TODO:

  • command name to be changed to earliest-keys
  • [ ] add an option to specify max_results as number or unlimited
  • add some small riak_test

@kuenishi kuenishi force-pushed the feature/gc-bucket-status branch from f0f4483 to 24a8109 Compare June 23, 2015 04:55
@kuenishi
Copy link
Contributor Author

Yay, this is ready again.

shino
shino reviewed Jun 24, 2015
View reviewed changes
rel/files/riak-cs-admin
@@ -31,7 +31,8 @@ case "$1" in
;;
*)
echo "Usage: $SCRIPT gc { batch [<leeway_seconds>|--help] | status | pause | resume | cancel |"
echo " set-interval <interval_seconds> | set-leeway <leeway_seconds> }"
echo " set-interval <interval_seconds> | set-leeway <leeway_seconds> |"
echo " earliest-keys [bag names]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does [bag names] mean options for command line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, it supposed to be. Will fix.

@Basho-JIRA
Copy link

Updated

_[posted via JIRA by Kota Uenishi]_

@Basho-JIRA Basho-JIRA closed this Jun 25, 2015
@kuenishi kuenishi reopened this Jun 25, 2015
@kuenishi kuenishi force-pushed the feature/gc-bucket-status branch from 7860da4 to 49c952f Compare June 25, 2015 07:41
@shino
Copy link
Contributor

shino commented Jun 25, 2015

All riak_test passed (except one known failure). Great for visibility improvement.

borshop added a commit that referenced this pull request Jun 25, 2015
@borshop
Merge pull request #1160 from basho/feature/gc-bucket-status
95b73b0 
Add subcommand to find oldest entries in GC bucket

Reviewed-by: shino
@shino
Copy link
Contributor

shino commented Jun 25, 2015

@borshop merge

@borshop borshop merged commit 49c952f into develop Jun 25, 2015
@kuenishi kuenishi deleted the feature/gc-bucket-status branch June 25, 2015 11:57
@Basho-JIRA
Copy link

Release note: Add a command to find oldest entry after epoch_start in garbage collection. With this command operators may keep informed of garbage collection progress.

_[posted via JIRA by Kota Uenishi]_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kuenishi kuenishi

Labels
JIRA: Closed
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kuenishi @Basho-JIRA @shino @borshop