riak-cs-debug update
#1116
Closed
riak-cs-debug update
#1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2015 17:36
Move in a number of updates that were previously made to riak-debug
Because riak-cs-debug will almost always be called in tandem with riak-debug, there's no need to include (by default) all these system calls in both archives.
|
Looks nice, but I don't have Solaris env. Anybody? |
|
The script will hang forever if there is no But aside from that, it appears to work correctly on Solaris: |
| @@ -325,6 +372,9 @@ if [ 1 -eq $get_syscmds ]; then | |||
| dump netstat_rn netstat -rn | |||
| dump pfctl_rules pfctl -s rules | |||
| dump pfctl_nat pfctl -s nat | |||
| dump java_version java -version | |||
|
On Ubuntu, this script failed: |
|
|
||
| # Use dump to execute the copy. This will provide a progress dot and | ||
| # capture any error messages. | ||
| dump cp_cfg cp -R "$cs_etc_dir"/*.conf* . |
There was a problem hiding this comment.
Gathering riak-cs.conf and advanced.config is also helpful for CSEs to figure out a mistake on the configs, isn't it?
|
Thank you for the effort to update this from latest riak-debug. |
I left a few comments.
|
Changes are included in #1236 (RCS-284). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a lot of updates made to
riak-debugthat have not yet been pulled intoriak-cs-debug. This PR looks to correct that.These changes have not yet been tested, though, and definitely need to be checked on Ubuntu and Solaris before being merged.