Add participate_in_2i_coverage riak option #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows marking of nodes 'down' in calculations for 2i coverage queries. In create_plan, it queries each node for the value of the participate_in_2i_coverage and treats those with the value set explicitly to `false` as 'down' for the calculation of avaiable vnodes. See related riak_kv commit that adds a default value to the KV schema. This is an operator feature. The operator must bring down the node, change the config, and start the node, for it to have effect.
This was referenced Mar 1, 2018
ghost
reviewed
Mar 4, 2018
| @@ -159,7 +159,13 @@ standard_join(Node, Ring, Rejoin, Auto) -> | |||
| node(), | |||
| gossip_vsn, | |||
| GossipVsn), | |||
| {_, Ring5} = riak_core_capability:update_ring(Ring4), | |||
| ParticipateInCoverage = app_helper:get_env(riak_core,participate_in_coverage), | |||
There was a problem hiding this comment.
All this Ring2, Ring3, Ring4, Ring4a, Ring5, Ring6 might be nicer as a fold - but that's outside the scope of this change request.
|
The structure looks OK - but I notice there are no tests for this new functionality - are they in a separate repository? |
|
Duh, just read comments above. |
|
Don't you think maybe your comments about the schema from basho/riak_kv#1664 should be on this PR? |
|
I don't mind which PR is used to do it. the cuttlefish one could be merged in (to here) first. |
|
I don't understand. |
|
Looks ok for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows marking of nodes 'down' in calculations for 2i coverage
queries. In create_plan, it queries each node for the value of the
participate_in_2i_coverage and treats those with the value set
explicitly to
falseas 'down' for the calculation of avaiablevnodes.
See related riak_kv commit that adds a default value to the KV schema.
This is an operator feature. The operator must bring down the node,
change the config, and start the node, for it to have effect.