pass NODETOOL_NODE_PREFIX to relx-generated script, spare some atoms #1079
Conversation
Each time riak status (and the like) is run, relx generates a unique id
which is then converted to an atom ("[email protected]") in
riak VM, eventually causing atom table exhaustion. Relx has been modified
to optionally generate a static id if NODETOOL_NODE_PREFIX env var is
present. Convenient when the caller guarantees calls are always
serialized.
|
Could you please explain here what happens if you do not set NODETOOL_NODE_PREFIX today and what would happen with your patch if you do not set this variable? Would it impact customers that don't bother using this env variable? |
|
If Customers are only to be advised to use this feature if they can guarantee their calls to |
|
Just a heads-up (apologies if you have already taken this into account): this feature should be mentioned in release announcement. Those who do periodic, and frequent enough, |
Each time
riak status(and the like) is run, relx generates a unique id which is then converted to an atom (of the form "[email protected]") in the riak VM to which it connects, eventually causing atom table exhaustion. Now that relx has been modified to optionally produce a static id ifNODETOOL_NODE_PREFIXenv var is present instead of generating a random id, let's make use of this. Convenient when the caller guarantees calls are always serialized.