Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: add own _print_elapsed_time #14

Merged
merged 3 commits into from
May 22, 2024

Conversation

JochenSiegWork
Copy link
Collaborator

- sklearn changed location of private _print_elapsed_time
  function in sklearn 1.5, which is breaking our code.
- To stay consistent but robust against such changes we
  adapted the print functions and implement them ourselves.
  This stops future code breaks due to location changes
  and we stick to a similar logging style as sklearn.
- If sklearn is doing major changes to their logging style
  we might should adapt in the future. However, that's
  rather unlikely.

    - sklearn changed location of private _print_elapsed_time
      function in sklearn 1.5, which is breaking our code.
    - To stay consistent but robust against such changes we
      adapted the print functions and implement them ourselves.
      This stops future code breaks due to location changes
      and we stick to a similar logging style as sklearn.
    - If sklearn is doing major changes to their logging style
      we might should adapt in the future. However, that's
      rather unlikely.
@JochenSiegWork JochenSiegWork self-assigned this May 22, 2024
@JochenSiegWork JochenSiegWork merged commit 77fca18 into main May 22, 2024
14 checks passed
@JochenSiegWork JochenSiegWork deleted the adapt_own_time_elapsed_from_sklearn branch May 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants