Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce __init__ code verbosity #60

Closed
JochenSiegWork opened this issue Aug 14, 2024 · 1 comment
Closed

Reduce __init__ code verbosity #60

JochenSiegWork opened this issue Aug 14, 2024 · 1 comment
Labels
status: completed Issue that was successfully solved type: enhancement New feature or request

Comments

@JochenSiegWork
Copy link
Collaborator

JochenSiegWork commented Aug 14, 2024 •
edited
Loading

We have some code redundancies in most pipeline elements' constructors. The code could potentially be reduced through inheritance as pointed out by @frederik-sandfort1 in #59 (review)_

We should investigate this. Less verbose code would also make it easier to write custom pipeline elements.
@c-w-feldmann c-w-feldmann added type: enhancement New feature or request status: backlog Things we will work on, but not right now labels Aug 14, 2024
@JochenSiegWork JochenSiegWork mentioned this issue Aug 15, 2024
Merged
@frederik-sandfort1 frederik-sandfort1 mentioned this issue Aug 21, 2024
Merged
@JochenSiegWork
Copy link
Collaborator Author

fixed in #70

@c-w-feldmann c-w-feldmann added status: completed Issue that was successfully solved and removed status: backlog Things we will work on, but not right now labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: completed Issue that was successfully solved type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c-w-feldmann @JochenSiegWork