Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mol2any: add mol2bool element #59

Merged
merged 1 commit into from
Aug 15, 2024
Merged

mol2any: add mol2bool element #59

merged 1 commit into from
Aug 15, 2024

Conversation

JochenSiegWork
Copy link
Collaborator 

- Add new MolToBool element that converts values to
  a bool array. Can be used for masking.

@JochenSiegWork
mol2any: add mol2bool element
e428e08 
    - Add new MolToBool element that converts values to
      a bool array. Can be used for masking.
@JochenSiegWork JochenSiegWork self-assigned this Aug 13, 2024
frederik-sandfort1
frederik-sandfort1 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@frederik-sandfort1 frederik-sandfort1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, thanks for implementing!

molpipeline/mol2any/mol2bool.py Show resolved Hide resolved
tests/test_elements/test_mol2any/test_mol2bool.py Show resolved Hide resolved
conrad-stork-basf
conrad-stork-basf approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@conrad-stork-basf conrad-stork-basf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me...

@JochenSiegWork JochenSiegWork mentioned this pull request Aug 14, 2024
Closed
@JochenSiegWork JochenSiegWork merged commit 634ecc4 into main Aug 15, 2024
14 checks passed
@JochenSiegWork JochenSiegWork deleted the mol_to_mask branch August 15, 2024 05:53
@c-w-feldmann c-w-feldmann added the type: enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederik-sandfort1 frederik-sandfort1 frederik-sandfort1 approved these changes

@conrad-stork-basf conrad-stork-basf conrad-stork-basf approved these changes

@c-w-feldmann c-w-feldmann c-w-feldmann approved these changes

Assignees

@JochenSiegWork JochenSiegWork

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JochenSiegWork @c-w-feldmann @frederik-sandfort1 @conrad-stork-basf