ブログ記事に対して追加でアソシエーションで繋げたデータが取得できない問題を改善

baserproject · Dec 11, 2024 · de0f110 · de0f110
1 parent 8522806
commit de0f110
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 50 deletions.
diff --git a/plugins/bc-blog/src/Model/Table/BlogPostsTable.php b/plugins/bc-blog/src/Model/Table/BlogPostsTable.php
@@ -20,6 +20,7 @@
 use BaserCore\Model\Table\UsersTable;
 use BaserCore\Utility\BcUtil;
 use BcBlog\Model\Entity\BlogPost;
+use Cake\Collection\CollectionInterface;
 use Cake\Core\Plugin;
 use Cake\Database\Driver\Mysql;
 use Cake\Database\Driver\Postgres;
@@ -860,4 +861,34 @@ public function getPublishByNo(int $blogContentId, mixed $no, bool $preview = fa
         return $entity;
     }
 
+    /**
+     * find all
+     * @param Query $query
+     * @param array $options
+     * @return Query
+     * @checked
+     * @noTodo
+     */
+    public function findAll(Query $query, array $options = []): Query
+    {
+        if($options['draft'] !== false) return $query;
+        return $query->formatResults(function(CollectionInterface $results) {
+            return $results->map([$this, 'excludeDraftFields']);
+        });
+    }
+
+    /**
+     * 草稿データを除外する
+     * @param EntityInterface $entity
+     * @return EntityInterface
+     * @checked
+     * @noTodo
+     */
+    public function excludeDraftFields(EntityInterface $entity)
+    {
+        unset($entity->content_draft);
+        unset($entity->detail_draft);
+        return $entity;
+    }
+
 }
diff --git a/plugins/bc-blog/src/Service/BlogPostsService.php b/plugins/bc-blog/src/Service/BlogPostsService.php
@@ -155,7 +155,8 @@ public function getIndex(array $queryParams = []): Query
         if ($options['id'] || $options['no']) $options['contain'][] = 'BlogComments';
         if ($options['contain'] == null)
             $options['contain'] = [];
-        $query = $this->BlogPosts->find()->contain($options['contain']);
+        $query = $this->BlogPosts->find('all', ['draft' => $options['draft']])
+            ->contain($options['contain']);
 
         if ($options['order']) {
             $query->orderBy($this->createOrder($options['order'], $options['direction']));
@@ -262,10 +263,6 @@ protected function createIndexConditions(Query $query, array $params)
             $conditions = $this->BlogPosts->getConditionAllowPublish();
             $conditions = array_merge($conditions, $this->BlogPosts->BlogContents->Contents->getConditionAllowPublish());
             $query->contain(['BlogContents' => ['Contents']]);
-            if($params['draft'] === false) {
-                $query->selectAllExcept($this->BlogPosts, ['content_draft', 'detail_draft']);
-                $query = $this->selectContains($query);
-            }
         } elseif ((string)$params['status'] === '0') {
             $conditions = ['BlogPosts.status' => false];
         } else {
@@ -350,51 +347,6 @@ protected function createIndexConditions(Query $query, array $params)
         return $query->where($conditions);
     }
 
-    /**
-     * Contains を select を前提として適用する
-     * select を利用した場合、関連テーブルのカラムを指定しないと、取得できないため
-     * @param Query $query
-     * @param array $contains
-     * @return Query
-     * @noTodo
-     * @checked
-     */
-    public function selectContains(Query $query, array $contains = [])
-    {
-        if(!$contains) $contains = $query->getContain();
-        if(isset($contains['BlogContents'])) {
-            $query->contain(['BlogContents' => function($q) {
-                return $q->select($this->BlogPosts->BlogContents);
-            }]);
-        }
-        if(isset($contains['BlogContents']['Contents'])) {
-            $query->contain(['BlogContents.Contents' => function($q) {
-                return $q->select($this->BlogPosts->BlogContents->Contents);
-            }]);
-        }
-        if(isset($contains['Users'])) {
-            $query->contain(['Users' => function($q) {
-                return $q->select($this->BlogPosts->Users);
-            }]);
-        }
-        if(isset($contains['BlogComments'])) {
-            $query->contain(['BlogComments' => function($q) {
-                return $q->select($this->BlogPosts->BlogComments);
-            }]);
-        }
-        if(isset($contains['BlogCategories'])) {
-            $query->contain(['BlogCategories' => function($q) {
-                return $q->select($this->BlogPosts->BlogCategories);
-            }]);
-        }
-        if(isset($contains['BlogTags'])) {
-            $query->contain(['BlogTags' => function($q) {
-                return $q->select($this->BlogPosts->BlogTags);
-            }]);
-        }
-        return $query;
-    }
-
     /**
      * カテゴリ条件を生成する
      *