Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any of the (sub)commands in
install.sh
fail, the install script will continue to run and effectively hide the fact that something went wrong. Settingset -e
will make the bash script exit upon an error.Context: I was just testing #29 in an
arm64
VM, and the installation ofmise
failed silently (because the current version does not have a code path forarm64
); however, it appeared as if the installation had worked correctly and I got logged out at the end of it.Then, when I tried to log in again, the system would simply hang. Upon further inspection, I realized it was hanging on this prompt:
omakub/defaults/bash/init
Line 4 in 9c603cd