Factor out version check code into a separate script. Call the script… #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in install.sh after the omakub clone in boot.sh
dhh
reviewed
Jul 12, 2024
check-version.sh
Outdated
| } | ||
|
|
||
| if check_ubuntu_version; then | ||
| echo "Script is running on Ubuntu 24.04 or higher. Continuing execution..." |
There was a problem hiding this comment.
Let's just stay quiet if operating system is correct. That's the default assumption. So only output anything if we're failing.
javajosh
commented
Jul 13, 2024
Comment on lines
24
to
27
| if ! check_ubuntu_version; then | ||
| echo "Script execution failed due to system requirements not being met." >&2 | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Remain silent on version check success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of my previous PR. The git history is clean now, and the code is improved: distro name is properly checked, and the awk version comparison code is simplified.
The main purpose of this PR is to help others avoid the footgun of installing omakub over Ubuntu 22, which is the current LTS release.