Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in dependency install step #97

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix syntax error in dependency install step #97

merged 1 commit into from
Mar 9, 2023

Conversation

martinbjeldbak
Copy link
Contributor

Minor syntax fix for missing opening parenthesis in the dependency install step, run if curl/docker aren't installed

Test is still passing as it wasn't checking for parenthesis

Running on fresh DigitalOcean Ubuntu 22.04 LTS box with MRSK v0.9.0 I get:

$ bin/mrsk deploy
Ensure curl and Docker are installed...
  INFO [432fcba0] Running which curl on xxx.xxx.xxx.xxx
  INFO [fd30bd5c] Finished in 0.560 seconds with exit status 1 (failed).
  INFO [c324ea51] Running apt-get update -y && apt-get install docker.io -y) on xxx.xxx.xxx.xxx
  Finished all in 3.9 seconds
  ERROR (SSHKit::Command::Failed): apt-get update -y && apt-get install docker.io -y) exit status: 2
apt-get update -y && apt-get install docker.io -y) stdout: Nothing written
apt-get update -y && apt-get install docker.io -y) stderr: bash: -c: line 1: syntax error near unexpected token `)'
bash: -c: line 1: `apt-get update -y && apt-get install docker.io -y)'

Cheers!

@dhh dhh merged commit 15e879e into basecamp:main Mar 9, 2023
@martinbjeldbak martinbjeldbak deleted the syntax-error-docker-install branch March 10, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants