Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim long hostnames #762

Merged
merged 1 commit into from
May 10, 2024
Merged

Trim long hostnames #762

merged 1 commit into from
May 10, 2024

Conversation

kryachkov
Copy link
Contributor

Reopening after messing up #614 after rebasing my fork

@djmb
Copy link
Collaborator

djmb commented May 7, 2024

Hi @kryachkov - there's a Rubocop error here - if you could fix that up, I'll merge this. Thanks!

Hostnames longer than 64 characters are not supported by docker
@kryachkov
Copy link
Contributor Author

kryachkov commented May 7, 2024

Hi @kryachkov - there's a Rubocop error here - if you could fix that up, I'll merge this. Thanks!

Fixed, not sure how I can retrigger the CI, thou

@djmb djmb merged commit 12cad54 into basecamp:main May 10, 2024
8 checks passed
jeremy added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants