Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default Traefik image to 2.10 #680

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

igor-alexandrov
Copy link
Contributor

Traefik 2.10 was released on April 24, 2023, since this 2.9 branch didn't get any updates and security fixes.

The 2.10 branch already got 7 patch releases, and even 2.11 was released one day ago.

This PR bumps default Traefik image to 2.10, after a couple of patch releases I plan to update default image to 2.11.

@morgoth
Copy link
Contributor

morgoth commented Feb 13, 2024

FYI: linking to the "migration guide" https://doc.traefik.io/traefik/v2.10/migration/v2/#v210 (which probably won't affect kamal)
and release https://github.com/traefik/traefik/releases/tag/v2.10.0

@igor-alexandrov
Copy link
Contributor Author

Yes, I forget to say, that I already switched several projects to 2.10.

@djmb djmb merged commit cb030e8 into basecamp:main Mar 4, 2024
7 checks passed
@morgoth
Copy link
Contributor

morgoth commented Mar 20, 2024

I updated to the new traefik version via kamal traefik reboot and for a a short time there was a 502 on the web. Maybe we should warn that the traefik update introduces small downtime?

@igor-alexandrov
Copy link
Contributor Author

@morgoth you got 502 not because an upgrade of the Traefik, but because kamal traefik reboot literally stops the container: https://github.com/basecamp/kamal/blob/main/lib/kamal/cli/traefik.rb#L23.

Maybe it would be good to add an interactive confirmation to the commands that can be potentially dangerous.

@djmb what do you think?

@morgoth
Copy link
Contributor

morgoth commented Mar 20, 2024

Yes, I know it is because of stopping it. I agree on the interactive confirmation addition

@igor-alexandrov
Copy link
Contributor Author

Thanks @morgoth! I will take care of this.

@djmb
Copy link
Collaborator

djmb commented Mar 20, 2024

@igor-alexandrov - yes that's a good idea 👍

We should also add a -y option to allow confirmations to be skipped

@igor-alexandrov
Copy link
Contributor Author

Sure, will do.

@igor-alexandrov
Copy link
Contributor Author

@djmb done #730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants