require missing net/scp dependency #645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
A couple of days ago, the github actions I have that automate the deployment of rails apps with kamal, started failing when running
kamal envify
, with the following error:I tracked down the issue to one of the most recent releases of capistrano/sshkit, which removed
require 'net/scp'
The capistrano release which no longer requires net/scp is v1.22.0 introduced in capistrano/sshkit#524
Steps to reproduce
kamal envify
)The fix
lib/kamal/sshkit_with_ext.rb
brings back the scp functionality.I believe this is very similar to #635 which @mdkent did 2 weeks ago
This change fixes #644