Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for proxy_command to run_over_ssh #327

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Add support for proxy_command to run_over_ssh #327

merged 1 commit into from
Jun 18, 2023

Conversation

mattyr
Copy link
Contributor

@mattyr mattyr commented Jun 5, 2023

Fixes the Commands::Base's run_over_ssh function to support ssh proxy configuration with proxy_command.

@djmb
Copy link
Collaborator

djmb commented Jun 15, 2023

@mattyr - could you rebase this against main and I'll run the tests? They were failing due to an unrelated issue fixed in #328.

@mattyr
Copy link
Contributor Author

mattyr commented Jun 16, 2023

done!

@dhh dhh merged commit 2007ab4 into basecamp:main Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattyr @djmb @dhh