Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to re-encrypt RDS instance and RDS Cluster snapshots when
shelvery_reencrypt_kms_key_id
is supplied.RDS Cluster Example
shelvery_reencrypt_kms_key_id
to the ARN of the new KMS key we want to re-encrypt our snapshots with aswell asshelvery_share_aws_account_ids
with the account we are sharing with.shelvery rds_cluster create_backups
shelvery_reencrypt_kms_key_id
parameter is set, it will then begin creating the new re-encrypted snapshot.Note - Shelvery updates the tags of the new snapshot to match the new name
shelvery:name : shelvery-test-2023-04-18-0025-daily-re-encrypted
shelvery rds_cluster pull_shared_backups
from our destination account, observe that Shelvery now creates the local manual snapshot in the destination account with the new re-encrypted snapshot.RDS Instance Example
shelvery rds create_backups
shelvery rds pull_shared_backups
and observe the manual snapshot is created in the destination accountOther resources
The code for re-encrypting RDS Instance and cluster snapshots should not interfere with other resource types even when the
shelvery_reencrypt_kms_key_id
as the only change toengine.py
is to return the new backup id of the re-encrypted snapshot which only occurs for RDS resources.