Add verify.walletconnect.org to frame-src #1532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently both WalletConnect and Rabby (which apparently uses WalletConnect) are broken on base.org. As a result, the BitBox02 hardware wallet is currently unusable with base.org. I see blocked requests to both verify.walletconnect.com and verify.walletconnect.org to the same URL path; [apps/base-docs/server.js][0] only uses the latter, so I’m assuming only one of them is needed and updated this to match. [0]: https://github.com/base-org/web/blob/9beb94e4201224dea6234d2a061c9855f5133fd1/apps/base-docs/server.js#L436
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@mrdomino is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
|
@mrdomino I was able to use WalletConnect on base.org just now, without merging these changes. could you clarify the issue here? |
|
I was able to as well! I don’t know what changed. |
|
@mrdomino hmm, not sure, perhaps some sort of rabby / walletconnect issue. For now I'm going to close this out, but please let me know if you see again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both WalletConnect and Rabby (which apparently uses WalletConnect) are broken on base.org. As a result, the BitBox02 hardware wallet is currently unusable with base.org.
I see blocked requests to both verify.walletconnect.com and verify.walletconnect.org to the same URL path; I have added both and confirmed (by locally overriding the response header) that this works with Rabby.
Fixes #1531.