Add D2 Finance #1355
Closed
Add D2 Finance #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
|
@HWxFrank is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
Heya! Thanks for building on Base! We require that defi apps linked to from base.org include a terms of service / terms and conditions page for users. It doesn't appear that this is present on the linked page. In order to continue the review, could you all please update and resubmit? |
|
Hey wbnns,
The page submitted has a full ofac compliance notice, disclaimer/link to
addition disclaimers, requires users to accept terms before accessing the
dapp
I believe this should be sufficient?
…On Fri, Dec 13, 2024 at 18:20 wbnns ***@***.***> wrote:
@HWxFrank <https://github.com/HWxFrank>
Heya! Thanks for building on Base!
We require that defi apps linked to from base.org include a terms of
service / terms and conditions page for users. It doesn't appear that this
is present on the linked page. In order to continue the review, could you
all please update and resubmit?
—
Reply to this email directly, view it on GitHub
<#1355 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A23LR5XTEZUJBLEEN5OXJTD2FNTVDAVCNFSM6AAAAABTGYZJB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBSGUZTOMRXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?