Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs updated for The Graph: Supports both mainnet & testnet. +Cleanup #1305

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

alinobrasil
Copy link
Contributor

What changed? Why?

  • Supported networks - Only showed mainnet. The Graph supports both Mainnet & Testnet
  • Overall wording - Simplified to highlight benefits/features in bullet points.

Notes to reviewers
We wanted to make sure devs know they can build subgraphs on Testnet too, to make their transition to mainnet as seameless as possible.
The docs were also updated to be clear & concise with The Graph's benefits & features.

How has it been tested?
Looks fine locally.

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:02pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:02pm

Copy link

vercel bot commented Nov 26, 2024

@alinobrasil is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 26, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alinobrasil Thanks for building on Base 🔵

@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2024-12-06 17:26:27 UTC
User failed mfa authentication, see go/mfa-help

@wbnns wbnns enabled auto-merge (squash) December 6, 2024 22:41
@cb-heimdall
Copy link
Collaborator

Review Error for hughescoin @ 2024-12-09 22:45:32 UTC
User cannot review their own commit

@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2024-12-10 01:50:01 UTC
User failed mfa authentication, see go/mfa-help

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alinobrasil Thanks!

@wbnns wbnns merged commit dc84d2c into base-org:master Dec 19, 2024
7 checks passed
chrischang pushed a commit to chrischang/web that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants